Skip to content

Update sineWave example of AnalogWave core library #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2023
Merged

Update sineWave example of AnalogWave core library #55

merged 1 commit into from
Jul 24, 2023

Conversation

jacobhylen
Copy link
Contributor

SineWave example of the AnalogWave library was using A0 as an input pin, but the A0 pin is the DAC output pin.
https://forum.arduino.cc/t/invalid-r4-sinewave-ino-example/1149139

This PR changes the potentiometer input pin to A5, to match the other DAC examples in the library.

aentinger
aentinger approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aentinger aentinger merged commit 3441adc into arduino:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aentinger aentinger aentinger approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobhylen @aentinger